Skip to content

variant support #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

variant support #836

wants to merge 13 commits into from

Conversation

ravlio
Copy link
Contributor

@ravlio ravlio commented May 16, 2025

No description provided.

osipovartem
osipovartem reviewed May 16, 2025
View reviewed changes
@ravlio ravlio force-pushed the maxim/merge-variant branch from ff8e76a to 96d50e7 Compare May 20, 2025 14:30
@rampage644 rampage644 mentioned this pull request May 21, 2025
Open
@ravlio ravlio force-pushed the maxim/merge-variant branch from 96d50e7 to 178e750 Compare May 22, 2025 10:51
@ravlio ravlio requested review from rampage644, osipovartem and Vedin and removed request for rampage644, Vedin and osipovartem May 22, 2025 10:59
@ravlio ravlio force-pushed the maxim/merge-variant branch 2 times, most recently from 983e3e6 to f86578a Compare May 27, 2025 10:33
@rampage644
Copy link
Contributor

@ravlio Anything else blocking this PR to be merged?

@ravlio
Copy link
Contributor Author

ravlio commented May 29, 2025 •
edited
Loading

@rampage644 nope, just wanted to gather reviews. Working on resolving conflicts and merging. Please re-approve

@ravlio ravlio force-pushed the maxim/merge-variant branch from 2f35e24 to 09bdbc8 Compare May 29, 2025 11:03
osipovartem
osipovartem reviewed May 29, 2025
View reviewed changes
Vedin
Vedin approved these changes May 29, 2025
View reviewed changes
Copy link
Contributor

@Vedin Vedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ! I didn't check all functions one by one. I think we should merge this and fix all potential problems later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vedin Vedin Vedin approved these changes

@osipovartem osipovartem osipovartem left review comments

@rampage644 rampage644 rampage644 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ravlio @rampage644 @Vedin @osipovartem